Cleanup and remove duplicate variable #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jandom
commented
Feb 7, 2021
- pulumi_vpc_id is the same as pulumi_vpc
- pulumi_vpc_id is the same as pulumi_vpc
|
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR |
pierskarsenbarg
approved these changes
Feb 7, 2021
|
The failing tests seems related to incorrect credentials, don't think this will ever work for external contributions such a this
|
stack72
approved these changes
Feb 7, 2021
|
@jandom that Credentials issue is because of a small bug in my GHA conditional :/ thanks for spotting that! |
|
Many thanks @stack72 @pierskarsenbarg – this was such a quick and nice PR! |
dixler
pushed a commit
that referenced
this pull request
Jan 21, 2022
This was referenced Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.