Update examples for updated AWS managed policies #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2021
| [<AutoOpen>] | ||
| module Helpers = | ||
| let inputLeft<'a, 'b>(v: 'a) : InputUnion<'a, 'b> = InputUnion.op_Implicit v | ||
| let inputRight<'a, 'b>(v: 'b) : InputUnion<'a, 'b> = InputUnion.op_Implicit v |
There was a problem hiding this comment.
We have standard helpers to do that https://github.com/pulumi/pulumi/blob/master/sdk/dotnet/Pulumi.FSharp/Library.fs#L39-L44
Co-authored-by: Mikhail Shilkov <[email protected]>
mikhailshilkov
approved these changes
Jan 29, 2021
dixler
pushed a commit
that referenced
this pull request
Jan 21, 2022
Co-authored-by: Mikhail Shilkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update examples that used either the outdated
AmazonEC2ContainerServiceFullAccessorAWSLambdaFullAccesspolicies. While at it, fix up some of these examples.@mikhailshilkov I updated an F# example for the recent changes to
InputUnionenum types. I am not super familiar with F#, so would like your opinion on that change (I copied an example from how I had seen you do it elsewhere).I'll note that I ran all these examples manually to verify they work. I had three issues:
up. A subsequentupseems to fix this. This requires more investigation but I suspect an issue with Python snake/camel casing.