fixed bugs in the Azure Key Vault secret provider readme #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Jul 1, 2020
| @@ -25,7 +27,7 @@ az keyvault create -l westus -n pulumi --resource-group $RESOURCE_GROUP_NAME | |||
| az keyvault key create --name pulumi-secret --vault-name pulumi | |||
|
|
|||
| # Finally, set the relevant permissions on the keyvault | |||
| az keyvault set-policy --name pulumi --object-id $YOUR_OBJECT_ID --key-permissions decrypt get create delete list update import backup restore recover | |||
| az keyvault set-policy --name pulumi --object-id $YOUR_OBJECT_ID --key-permissions decrypt get create delete list update import backup restore recover encrypt | |||
There was a problem hiding this comment.
Without the encrypt permission set here, you'll get 403 errors back during pulumi init
Aaronontheweb
commented
Jul 1, 2020
| @@ -17,6 +17,8 @@ You should also ensure: | |||
|
|
|||
| ## Create an Azure Keyvault Key | |||
|
|
|||
| > `$YOUR_OBJECT_ID` in this case corresponds to the object ID of the Azure ServicePrincipal or account currently logged into the `az` CLI. You will likely need to run a ` az ad sp show --id {app id} | jq -r .objectId` or `az ad user show --id {user id}` query to get this value. | |||
There was a problem hiding this comment.
Not necessary, but added it to make life easier
|
Thanks for the contribution! |
|
Thank you!!! Ignore these failed tests - we just added a step that doesn't seem to work from forks :/ Will fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.