serverless-raw example language conversion #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 26, 2020 18:39
…verless-raw to a python project
…verless-raw to a python project
added 3 commits
June 29, 2020 18:53
…th aws-py-serverless-raw and aws-ts-serverless-raw
justinvp
requested changes
Jun 30, 2020
added 2 commits
June 30, 2020 12:07
…sioned_concurrent_executions 3.aws-py-serverless-raw fix Pulumi.yaml
justinvp
approved these changes
Jun 30, 2020
Comment on lines
+16
to
+18
| ## Deploying and running the Pulumi App | ||
| 1. Install dependencies. In this example we will install them in a virtual environment named `venv`. | ||
| ```bash |
There was a problem hiding this comment.
Nit: Add blank lines between the header and bullets. We have a tool that generates documentation tutorial pages on www.pulumi.com based on these examples, and the markdown renderer used to render pages on the website sometimes has trouble if there aren't blank lines between markdown elements.
Suggested change
| ## Deploying and running the Pulumi App | |
| 1. Install dependencies. In this example we will install them in a virtual environment named `venv`. | |
| ```bash | |
| ## Deploying and running the Pulumi App | |
| 1. Install dependencies. In this example we will install them in a virtual environment named `venv`. | |
| ```bash |
There was a problem hiding this comment.
Oh I am so sorry. I forgot to click on approval message. I will do that with my second language conversion pull request
dixler
pushed a commit
that referenced
this pull request
Jan 21, 2022
1. Change the netcore version to 3.1 2. Converted the project aws-ts-serverless-raw into aws-py-serverless-raw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the version of netcoreapp to 3.1 in aws-ts-serverless-raw.
Converted the aws-ts-serverless-raw to a python project aws-py-serverless-raw with the 3.1 netcoreapp version.