Make samples compatible with Node 6 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehoban
approved these changes
Jun 7, 2018
| environment: { | ||
| "S3_BUCKET": bucketName.get(), | ||
| "INPUT_VIDEO": file, | ||
| "TIME_OFFSET": framePos, | ||
| "OUTPUT_FILE": thumbnailFile, | ||
| }, | ||
| }).then(() => { // If using Node 8, can change this to `async/await` |
There was a problem hiding this comment.
I'd just leave off the comment - that will be clear enough to anyone who is interested in using async/await. (If all JavaScript code which could potentially use async/await needed a comment like this - there would be a lot of comments! :-))
|
LGTM, ready to merge? |
ramene
pushed a commit
to ramene/pulumi-kubeflow-ml
that referenced
this pull request
Sep 7, 2019
* Make samples compatible with Node 6
ramene
pushed a commit
to ramene/pulumi-kubeflow-ml
that referenced
this pull request
Sep 13, 2019
* Make samples compatible with Node 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.