Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved the documentation for examples/gcp-py-instance-nginx #710

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Improved the documentation for examples/gcp-py-instance-nginx #710

merged 2 commits into from
Jun 17, 2020

Conversation

jetvova
Copy link
Contributor

@jetvova jetvova commented Jun 16, 2020

  • Replaced "cncf-230209" with "YOURPROJECTID" to avoid confusion
  • Fixed pulumi stack output command to use the right name

leezen
leezen approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@leezen leezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing these out and submitting a fix

@leezen leezen merged commit 53e7350 into pulumi:master Jun 17, 2020
dixler pushed a commit that referenced this pull request Jan 21, 2022
@jetvova
Improved the documentation for examples/gcp-py-instance-nginx (#710)
ef3e225 
* Replaced "cncf-230209" with "YOURPROJECTID" to avoid confusion
* Fixed pulumi stack output command to use the right name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leezen leezen leezen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jetvova @leezen