Remove use of master/slave terminology in Guestbook examples #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes all remaining usage of master/slave terminology from the Pulumi examples. This required moving away from the upstream Docker images used in the Kubernetes Guestbook example at https://github.com/kubernetes/examples/tree/master/guestbook and https://kubernetes.io/docs/tutorials/stateless-application/guestbook/. Instead, we have forked these and made necessary changes to support alternative terminology in https://github.com/pulumi/guestbook, and published those updated images to `pulumi/guestbook-php-redis` and `pulumi/guestbook-redis-replica` on DockerHub.
stack72
approved these changes
Jun 12, 2020
lblackstone
approved these changes
Jun 12, 2020
lukehoban
force-pushed
the
lukehoban/guestbook-leader-replica
branch
from
3ea47f7
to
ed644da
Compare
dixler
pushed a commit
that referenced
this pull request
Jan 21, 2022
This PR removes all remaining usage of master/slave terminology from the Pulumi examples. This required moving away from the upstream Docker images used in the Kubernetes Guestbook example at https://github.com/kubernetes/examples/tree/master/guestbook and https://kubernetes.io/docs/tutorials/stateless-application/guestbook/. Instead, we have forked these and made necessary changes to support alternative terminology in https://github.com/pulumi/guestbook, and published those updated images to `pulumi/guestbook-php-redis` and `pulumi/guestbook-redis-replica` on DockerHub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all remaining usage of "master"/"slave" terminology from the Pulumi examples.
This required moving away from the upstream Docker images used in the Kubernetes Guestbook example at https://github.com/kubernetes/examples/tree/master/guestbook and https://kubernetes.io/docs/tutorials/stateless-application/guestbook/.
Instead, we have forked these and made necessary changes to support alternative terminology in https://github.com/pulumi/guestbook, and published those updated images to
pulumi/guestbook-php-redisandpulumi/guestbook-redis-replicaon DockerHub.