Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensuring we notify slack on build failures #696

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Ensuring we notify slack on build failures #696

merged 1 commit into from
Jun 8, 2020

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jun 8, 2020

Fixes: #684

@stack72 stack72 force-pushed the stack72/gh-684 branch 3 times, most recently from 861cadb to 19dea2e Compare June 8, 2020 19:49
@stack72 stack72 requested a review from jaxxstorm June 8, 2020 20:10
@stack72 stack72 self-assigned this Jun 8, 2020
leezen
leezen approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@leezen leezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unfortunate we have to repeat the same block per section, but I also don't know of a better way to do this in GHA

@stack72
Copy link
Contributor Author

stack72 commented Jun 8, 2020

This is also going to change to be under codegen so we can swap it out when GH allows meta actions ;)

@stack72 stack72 merged commit b0d4b6e into master Jun 8, 2020
@pulumi-bot pulumi-bot deleted the stack72/gh-684 branch June 8, 2020 21:04
dixler pushed a commit that referenced this pull request Jan 21, 2022
@stack72
Merge pull request #696 from pulumi/stack72/gh-684
2065b1f 
Ensuring we notify slack on build failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leezen leezen leezen approved these changes

@jaxxstorm jaxxstorm Awaiting requested review from jaxxstorm

Assignees

@stack72 stack72

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo examples status from GHA back to Slack
2 participants
@stack72 @leezen