Update the Go unit test example #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBoyle
approved these changes
Apr 1, 2020
Well, this is a unit test with mocks, so the test doesn't care about the region as it does not do anything "real" with AWS. |
|
The example is still deployable though no? I guess the readme doesn't specify any instructions on deploying the app. |
|
It hopefully is, but I focused README's of all unit tests on simply running the tests. If you think we should improve that, do you mind opening a separate issue? I don't think I can get to this today. Thanks! |
|
Merging as this example has no effect on the build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out of #615 for faster turnaround