Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup StackReference Architecture example #547

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Fixup StackReference Architecture example #547

merged 1 commit into from
Feb 11, 2020

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Feb 10, 2020

Fixes: #544

@stack72
Copy link
Contributor Author

stack72 commented Feb 10, 2020

Build fails due to:

Error: Cannot find module 'js-yaml'

@stack72 stack72 self-assigned this Feb 10, 2020
mikhailshilkov
mikhailshilkov approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the JSON file

aws-stackreference-architecture/networking/test.json Outdated Show resolved Hide resolved
@stack72 stack72 merged commit 1e37d9c into master Feb 11, 2020
@stack72 stack72 deleted the fix-stackreference branch February 11, 2020 12:58
dixler pushed a commit that referenced this pull request Jan 21, 2022
@stack72
Fixup StackReference Architecture example (#547)
a0fe350 
Fixes: #544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhailshilkov mikhailshilkov mikhailshilkov approved these changes

@lukehoban lukehoban Awaiting requested review from lukehoban

Assignees

@stack72 stack72

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-stackreference-architecture/networking broken?
2 participants
@stack72 @mikhailshilkov