Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing up the digitalocean-ts-k8s droplet slug #472

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Nov 20, 2019

No description provided.

Copy link
Member

@pgavlin pgavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change that hasn't been released yet, correct? Is it worth maintaining backcompat with prior versions by keeping both the misspelled and correctly spelled definitions?

cc @lukehoban

@stack72
Copy link
Contributor Author

stack72 commented Nov 25, 2019

@pgavlin i was kinda going with the example set in Cyrus’s document from before. This doesn’t feel like a breaking change as it doesn’t cause a recreation of any resources. I agree it’s not ideal though but when we automate these, we are doing to fall into the same category where an instance size isn’t supported and therefore we won’t have it in our union helpers

Totally up for discussing the best way forward in these though as I’m not tied to a specific direction

@pgavlin
Copy link
Member

pgavlin commented Nov 25, 2019

That seems reasonable enough to me. We'll need to do a release of the DO package in concert with this PR in order to keep things green.

@stack72 stack72 merged commit 5e15b35 into master Nov 25, 2019
@pulumi-bot pulumi-bot deleted the stack72-fix-do-slub branch November 25, 2019 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants