Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial to conform to future guidelines #375

Merged
merged 4 commits into from
Sep 11, 2019
Merged

Conversation

bermudezmt
Copy link
Contributor

Related to pulumi/docs#1636

@bermudezmt bermudezmt added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Sep 10, 2019
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.


1. Run `pulumi up` to preview and deploy changes:
```
$ cd infrastructure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think $ cd infrastructure should move up to be the first line in step 1 (before creating a stack).

@bermudezmt bermudezmt merged commit f2259b4 into master Sep 11, 2019
@pulumi-bot pulumi-bot deleted the maria/fix-1636 branch September 11, 2019 23:34
dixler pushed a commit that referenced this pull request Jan 21, 2022
* Update tutorial to conform to future guidelines

Related to pulumi/docs#1636

* Remove deploy button

* Address feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants