Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to examples explaining that pulumi/cloud is a preview package #353

Merged
merged 3 commits into from
Jul 31, 2019

Conversation

CyrusNajmabadi
Copy link
Contributor

No description provided.

@CyrusNajmabadi
Copy link
Contributor Author

@lukehoban @bermudezmt to help with wordsmithing.

Copy link
Contributor

@bermudezmt bermudezmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion, but I'll approve so I'm not blocking this. Thanks, @CyrusNajmabadi

// Copyright 2016-2017, Pulumi Corporation. All rights reserved.
// Copyright 2016-2018, Pulumi Corporation. All rights reserved.

// Note: @pulumi/cloud is a preview package demonstrating how to create cross-cloud pulumi
Copy link
Contributor

@bermudezmt bermudezmt Jul 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: @pulumi/cloud is a preview package demonstrating how to create cross-cloud Pulumi components. If you are targeting a specific cloud like AWS, Azure, or GCP, we recommend you use platform-specific packages like @pulumi/aws, @pulumi/azure or @pulumi/gcp. A platform-specific package gives you full access to the breadth of its capabilities and comes with many abstractions to make development easier.

How about changing it to that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@CyrusNajmabadi CyrusNajmabadi merged commit 72959d0 into master Jul 31, 2019
@pulumi-bot pulumi-bot deleted the cloudPreview branch July 31, 2019 02:58
ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this pull request Sep 7, 2019
ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this pull request Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants