Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AWS Serverless RAW example #310

Merged
merged 3 commits into from
Jun 18, 2019

Conversation

mikhailshilkov
Copy link
Member

Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - a couple suggestions to further simplify.

aws-ts-serverless-raw/index.ts Outdated Show resolved Hide resolved
aws-ts-serverless-raw/index.ts Outdated Show resolved Hide resolved
@lukehoban lukehoban merged commit 0b7565f into pulumi:master Jun 18, 2019
ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this pull request Sep 7, 2019
* Update to dotnet21 and improve policy

* Use assumeRolePolicyForPrincipal

* Simplify with RolePolicy
ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this pull request Sep 13, 2019
* Update to dotnet21 and improve policy

* Use assumeRolePolicyForPrincipal

* Simplify with RolePolicy
dixler pushed a commit that referenced this pull request Jan 21, 2022
* Update to dotnet21 and improve policy

* Use assumeRolePolicyForPrincipal

* Simplify with RolePolicy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants