Fix TypeScript compilation error in aws-ts-apigateway #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We know the pathParameters array will not be null, because we capture parameters in our route.
TypeScript was complianing a little later on when we tried to Buffer.from `event.body` since it may be null.
|
Our nightly CI Job hit this: https://travis-ci.com/pulumi/examples/jobs/193926229 |
CyrusNajmabadi
approved these changes
Apr 18, 2019
|
INteresting. i wonder if TS got stricter. This was fine when originally written... |
ramene
pushed a commit
to ramene/pulumi-kubeflow-ml
that referenced
this pull request
Sep 7, 2019
Fix TypeScript compilation error in aws-ts-apigateway
ramene
pushed a commit
to ramene/pulumi-kubeflow-ml
that referenced
this pull request
Sep 13, 2019
Fix TypeScript compilation error in aws-ts-apigateway
dixler
pushed a commit
that referenced
this pull request
Jan 21, 2022
Fix TypeScript compilation error in aws-ts-apigateway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We know the pathParameters array will not be null, because we capture
parameters in our route.