Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Null Assertion operator to pathParameters!["route"] Access #281

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Add Null Assertion operator to pathParameters!["route"] Access #281

merged 1 commit into from
Apr 18, 2019

Conversation

jestrjk
Copy link
Contributor

@jestrjk jestrjk commented Apr 17, 2019

This is a small change from the previous comments on this issue where as the event variable wasn't the problem, being passed in from the event Handler calling mechanism. It was accessing an untyped(?) event object property pathParameters which was causing the TS compile error.

Our ts compiler is slightly different versions mine being:

$tsc --version
Version 3.5.0-dev.20190409

This is a small change from the previous comments on this issue where as the event variable wasn't the problem, being passed in from the event Handler calling mechanism. It was accessing an untyped(?) event object property `pathParameters` which was causing the TS compile error.

Our ts compiler is slightly different versions mine being:
```
$tsc --version
Version 3.5.0-dev.20190409
```
@ellismg
Copy link
Contributor

ellismg commented Apr 18, 2019

It was accessing an untyped(?) event object property pathParameters which was causing the TS compile error.

It actually looks like the type just includes null as a possibility. Was surprised this ever worked! Thank you for the fix!

Copy link
Contributor

@ellismg ellismg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ellismg ellismg merged commit faba851 into pulumi:master Apr 18, 2019
ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this pull request Sep 7, 2019
Add Null Assertion operator to pathParameters!["route"] Access
ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this pull request Sep 13, 2019
Add Null Assertion operator to pathParameters!["route"] Access
dixler pushed a commit that referenced this pull request Jan 21, 2022
Add Null Assertion operator to pathParameters!["route"] Access
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants