Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure version of webserver #27

Merged
merged 2 commits into from
Mar 29, 2018
Merged

Conversation

lukehoban
Copy link
Member

Initial example using Azure package. Similar to the webserver example, but with differences related to how Azure manages VMs.

Fixes #26.

Initial example using Azure package.  Similar to the webserver example, but with differences related to how Azure manages VMs.
Copy link
Contributor

@lindydonna lindydonna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the minor feedback

$ pulumi config set azure:environment public
$ pulumi config set username testuser
$ pulumi config set --secret password <yourpassword>
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should explain that this is the username and password for the VM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be helpful to link to the password requirements. Got an error after deploying, since my password was not sufficiently complex. Article: https://docs.microsoft.com/en-us/azure/virtual-machines/windows/faq#what-are-the-password-requirements-when-creating-a-vm

$ az login
```

Preview the deployment of the application:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a step to restore NPM packages.


let userData =
`#!/bin/bash
nohup python -m SimpleHTTPServer 80 &`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to add a line for echo "Hello, World!" > index.html

@lukehoban lukehoban merged commit 88c79b4 into master Mar 29, 2018
@lukehoban lukehoban deleted the lukehoban/webserver-azure branch March 29, 2018 00:54
ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this pull request Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants