Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify promise code in s3-lambda-copyzip #256

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

lukehoban
Copy link
Member

Use async to simplify the code.

Use `async` to simplify the code.
@lukehoban lukehoban requested a review from joeduffy March 11, 2019 16:36
Copy link
Member

@joeduffy joeduffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is AWESOME! Thank you. I had thought async would simplify this, but didn't realize there was this handy promise() function on the AWS response objects.

Do you mind updating the blog post also?

@lukehoban lukehoban merged commit 954b4c0 into master Mar 11, 2019
@pulumi-bot pulumi-bot deleted the lukehoban/asynclambdacopyzip branch March 11, 2019 23:46
ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this pull request Sep 7, 2019
ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this pull request Sep 13, 2019
dixler pushed a commit that referenced this pull request Jan 21, 2022
Use `async` to simplify the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants