Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update voting app example to Output model #23

Merged
merged 2 commits into from
Mar 31, 2018

Conversation

lindydonna
Copy link
Contributor

Change from .then to .apply. Is there a simpler way to get endpoint of the redis cache, other than redisCache.endpoints.apply(endpoints => endpoints.redis[redisPort]);?

@lindydonna
Copy link
Contributor Author

@lukehoban Ping on this. Is there a simpler way to get endpoint of the redis cache, other than redisCache.endpoints.apply(endpoints => endpoints.redis[redisPort]);

Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Is there a simpler way to get endpoint of the redis cache, other than redisCache.endpoints.apply(endpoints => endpoints.redis[redisPort]);

Unfortunately no. Making this better is tracked in pulumi/pulumi-cloud#408, but we should do what you've done here for now.

@@ -2,10 +2,12 @@

import * as pulumi from "@pulumi/pulumi";
import * as cloud from "@pulumi/cloud";
import { Output } from "@pulumi/pulumi";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed? I would have assumed that the import of @pulumi/pulumi was sufficient. (Note that this may be a difference related to older versions of TypeScript?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I got a compilation error when I didn't use it, but I'll update the TS version and double-check.

@lindydonna lindydonna force-pushed the lindydonna/voting-app-updates branch from 248e58b to 3aac2a0 Compare March 31, 2018 01:47
@lindydonna lindydonna merged commit 17935ea into master Mar 31, 2018
@lindydonna lindydonna deleted the lindydonna/voting-app-updates branch March 31, 2018 02:02
ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this pull request Sep 7, 2019
* Update voting-app to 0.11 bits

* Address review feedback, add readme for voting app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants