Add example for multiple AKS clusters. #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully a clearer example name to not be confused with a single multi-region cluster.
justinvp
reviewed
Dec 6, 2018
|
@justinvp is there a linter or some other way to check that I don't have extraneous properties in my That aside, does this look good enough to merge in? |
justinvp
approved these changes
Dec 7, 2018
There was a problem hiding this comment.
A couple things to address, but LGTM otherwise!
is there a linter or some other way to check that I don't have extraneous properties in my
Pulumi.yamlfor next time?
We don't have a linter for Pulumi.yaml (at least that I'm aware of), but that might be worth thinking about doing at some point. In this particular case, the extra property was just a point-in-time thing that isn't needed anymore (I recently cleaned up all the existing examples in the repo).
Pull out config to config.ts to be consistent with other examples. Add disabled test.
ramene
pushed a commit
to ramene/pulumi-kubeflow-ml
that referenced
this pull request
Sep 7, 2019
* Add example for multiple AKS clusters.
ramene
pushed a commit
to ramene/pulumi-kubeflow-ml
that referenced
this pull request
Sep 13, 2019
* Add example for multiple AKS clusters.
dixler
pushed a commit
that referenced
this pull request
Jan 21, 2022
* Add example for multiple AKS clusters.
This was referenced May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.