Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL DB connection string #175

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Fix SQL DB connection string #175

merged 1 commit into from
Nov 12, 2018

Conversation

rgwood
Copy link
Contributor

@rgwood rgwood commented Nov 12, 2018

The azure.sql.SqlServer and azure.sql.Database objects are being passed through pulumi.all() and Output<t>.apply() instead of server+database name outputs. This results in an invalid connection string like Server=tcp:[object Object].database.windows.net;initial catalog=[object Object];user ID=pulumi...

Initially raised in this issue.

The `azure.sql.SqlServer` and `azure.sql.Database` objects are being passed through `pulumi.all()` and `Output<t>.apply()` instead of server+database name outputs. This results in an invalid connection string like `Server=tcp:[object Object].database.windows.net;initial catalog=[object Object];user ID=pulumi...`

Also raised in [this issue](pulumi#174).
Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@lukehoban lukehoban merged commit 29863c6 into pulumi:master Nov 12, 2018
@rgwood rgwood deleted the patch-1 branch November 12, 2018 05:06
ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this pull request Sep 7, 2019
The `azure.sql.SqlServer` and `azure.sql.Database` objects are being passed through `pulumi.all()` and `Output<t>.apply()` instead of server+database name outputs. This results in an invalid connection string like `Server=tcp:[object Object].database.windows.net;initial catalog=[object Object];user ID=pulumi...`

Also raised in [this issue](pulumi#174).
ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this pull request Sep 13, 2019
The `azure.sql.SqlServer` and `azure.sql.Database` objects are being passed through `pulumi.all()` and `Output<t>.apply()` instead of server+database name outputs. This results in an invalid connection string like `Server=tcp:[object Object].database.windows.net;initial catalog=[object Object];user ID=pulumi...`

Also raised in [this issue](pulumi#174).
dixler pushed a commit that referenced this pull request Jan 21, 2022
The `azure.sql.SqlServer` and `azure.sql.Database` objects are being passed through `pulumi.all()` and `Output<t>.apply()` instead of server+database name outputs. This results in an invalid connection string like `Server=tcp:[object Object].database.windows.net;initial catalog=[object Object];user ID=pulumi...`

Also raised in [this issue](#174).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants