Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pulumi-trace-tool to v0.0.1 #1606

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Update pulumi-trace-tool to v0.0.1 #1606

merged 1 commit into from
Mar 1, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Mar 1, 2024

The motivation is to land pulumi/pulumi-trace-tool@ddfac4d improvement in metrics.

Looks like go mod tidy also updates the Go toolchain.

@@ -1,11 +1,13 @@
module github.com/pulumi/examples/misc/test

go 1.20
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go1.20 EOL'd in Feb 6, 2024. Should be OK? Maybe merge and fix forward?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the tests are happy, so I see no reason not to bump to 1.21

@t0yv0 t0yv0 marked this pull request as ready for review March 1, 2024 21:40
Copy link

pulumi-staging bot commented Mar 1, 2024

🍹 The Update for pulumi/k8s-ci-cluster/f8495d9914421f96a4e795cc406b27b9932c2ad4-1726 was successful.

Resource Changes

    Name                                                          Type                                        Operation
+   password                                                      random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               create
+   primary-node-pool                                             gcp:container/nodePool:NodePool             create
+   gke                                                           pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-f8495d9914421f96a4e795cc406b27b9932c2ad4-1726  pulumi:pulumi:Stack                         create
+   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             create

Copy link
Member

@mjeffryes mjeffryes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@@ -1,11 +1,13 @@
module github.com/pulumi/examples/misc/test

go 1.20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the tests are happy, so I see no reason not to bump to 1.21

@t0yv0 t0yv0 merged commit 8d4d203 into master Mar 1, 2024
50 checks passed
@t0yv0 t0yv0 deleted the t0yv0/trace-tool-v0.0.1 branch March 1, 2024 22:30
Copy link

pulumi-staging bot commented Mar 1, 2024

🍹 The Destroy for pulumi/k8s-ci-cluster/f8495d9914421f96a4e795cc406b27b9932c2ad4-1726 was successful.

Resource Changes

    Name                                                          Type                                        Operation
-   primary-node-pool                                             gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               delete
-   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                      random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-f8495d9914421f96a4e795cc406b27b9932c2ad4-1726  pulumi:pulumi:Stack                         delete
-   gke                                                           pulumi:providers:kubernetes                 delete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants