Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aws-ts-localai-flowise example #1602

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

dirien
Copy link
Contributor

@dirien dirien commented Feb 26, 2024

No description provided.

@scottslowe
Copy link
Contributor

@dirien There are some tslint errors that need to be corrected before we can merge.

Also, I noted that your PR adds files in aws-go-langserve and aws-py-rag-pinecone, is that intentional?

@dirien
Copy link
Contributor Author

dirien commented Feb 26, 2024

Ups @scottslowe! Removed the files and fixed the linting!

Copy link
Contributor

@scottslowe scottslowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple very minor changes. There are a couple failing tests, but they do not appear to be related to this PR.

aws-ts-localai-flowise/README.md Outdated Show resolved Hide resolved
aws-ts-localai-flowise/README.md Outdated Show resolved Hide resolved
@dirien
Copy link
Contributor Author

dirien commented Feb 27, 2024

@scottslowe fixed both suggestions, ready to re-review!

Copy link
Contributor

@scottslowe scottslowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@dirien dirien merged commit ae6a0c4 into master Feb 28, 2024
50 of 51 checks passed
@dirien dirien deleted the aws-ts-localai-flowise branch February 28, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants