Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update langchain examples #1586

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

dirien
Copy link
Contributor

@dirien dirien commented Feb 12, 2024

No description provided.

@dirien dirien enabled auto-merge (squash) February 12, 2024 22:00
@dirien dirien force-pushed the dirien/cleanup-langserve-py-example branch from 0d50abf to f57e792 Compare February 13, 2024 12:48
@dirien
Copy link
Contributor Author

dirien commented Feb 13, 2024

closes #1587

@dirien dirien self-assigned this Feb 13, 2024
@dirien dirien changed the title fix: rename variables in lambda fix: update langchain examples Feb 13, 2024
@dirien dirien added this to the 0.100 milestone Feb 13, 2024
Copy link
Contributor

@scottslowe scottslowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great (love the new README files), but I don't think the Pinecone-related code should be in this PR, yes?

@dirien dirien force-pushed the dirien/cleanup-langserve-py-example branch from f57e792 to 046cd40 Compare February 13, 2024 13:40
@dirien
Copy link
Contributor Author

dirien commented Feb 13, 2024

@scottslowe: good catch! Removed it!

@dirien dirien merged commit e292687 into master Feb 13, 2024
50 of 51 checks passed
@dirien dirien deleted the dirien/cleanup-langserve-py-example branch February 13, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants