Three cloud example tests: cloud-js-containers, clouse-js-httpserver… #154
Conversation
… and cloud-ts-url-shortener-cache-http. Cloud-ts-url-shortener-cache-http is currently failing on the assert for reasons I am not sure of so I am going ahead and committing and pushing up to PR to get some feedback.
misc/test/examples_test.go
Outdated
| "url-shortener-cache:redisPassword": "s3cr7Password", | ||
| "cloud:provider": "aws", | ||
| // Use us-west-2 to assure fargate availability | ||
| "aws:region": "us-west-2", |
There was a problem hiding this comment.
Nit - but likely don’t need this anymore - Fargate is in all regions we’re likely to try running these tests.
There was a problem hiding this comment.
Hmm, ok, I though I had issues but us-west but i agree it would be better to just use the variable that all the other tests are using. i'll try changing.
There was a problem hiding this comment.
Oh - are we running these examples in us-west-1? That region isn’t generally fully up to date - should probably run in Oregon, Ohio, Virginia or Dublin just so we don’t run into regional service availability issues in the future.
misc/test/examples_test.go
Outdated
| // Use us-west-2 to assure fargate availability | ||
| "aws:region": "us-west-2", | ||
| "cloud-aws:useFargate": "true", | ||
| "cloud-aws:functionIncludePaths": "", |
There was a problem hiding this comment.
I am not sure, it is in the example readme (https://github.com/pulumi/examples/tree/master/cloud-ts-url-shortener-cache-http)
- Add the 'www' directory to the uploaded function code so it can be served from the http server:
$ pulumi config set cloud-aws:functionIncludePaths
#or
$ pulumi config set cloud-azure:functionIncludePaths
There was a problem hiding this comment.
Hmm - sounds like this might be needed but that the comment in the readme was missing some text. Cc @CyrusNajmabadi.
misc/test/examples_test.go
Outdated
| @@ -233,6 +280,7 @@ func assertHTTPResultWithRetry(t *testing.T, output interface{}, maxWait time.Du | |||
| count, sleep := 0, 0 | |||
| for true { | |||
| now := time.Now() | |||
| fmt.Println("Getting hostname: " + hostname) | |||
There was a problem hiding this comment.
These fmt.Println calls seem to be making output from tests hard to read (not getting prefixed). Should we be using t.Log?
There was a problem hiding this comment.
Yes, this left from some debugging and should be removed. I don't expect the 3rd test to pass right now, it is not on my machine due to the payload not matching expectations. The example works on my machine but running it in the test runner it failes. I am stumped on the issue so I thought I'd PR it so I can share it and perhaps get some insights.
|
The CI run failed as I expected but I don't see a link to the logs themselves. On my machine I am getting a failure in the assertion (pulumi update seems to succeed): Does this look familiar at all? I am stumped on why we are getting this payload rather than the expected web page (which I get when I run the example as specified in the example's readme). |
|
Travis logs are now two clicks away - pretty hard to find unfortunately after recent Travis changes to only use GitHub Checks. But they are there. |
cloud-ts-url-shortener-cache-http. Other minor PR feedback.
|
Created a bug for the cloud-ts-url-shortener-cache-http example (#155) and commented out the validation with a TODO. |
Three cloud example tests: cloud-js-containers, clouse-js-httpserver…
Three cloud example tests: cloud-js-containers, clouse-js-httpserver…
Three cloud example tests: cloud-js-containers, clouse-js-httpserver…
…, and cloud-ts-url-shortener-cache-http. Cloud-ts-url-shortener-cache-http is currently failing on the assert for reasons I am not sure of so I am going ahead and committing and pushing up to PR to get some feedback.