Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TypeScript Example for Azure OIDC with ESC #1529

Merged
merged 9 commits into from
Nov 30, 2023

Conversation

toriancrane
Copy link
Contributor

Adding TypeScript Example for Azure OIDC with ESC

@toriancrane toriancrane requested a review from a team November 17, 2023 15:49
Copy link
Contributor

@scottslowe scottslowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor changes, plus it looks like there are some linting failures that need to be addressed.

azure-ts-oidc-provider-pulumi/Pulumi.yaml Outdated Show resolved Hide resolved
azure-ts-oidc-provider-pulumi/Pulumi.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@desteves desteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions

Copy link
Contributor

@scottslowe scottslowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change needed, otherwise looks good

azure-ts-oidc-provider-pulumi/README.md Outdated Show resolved Hide resolved
@toriancrane toriancrane merged commit 940538d into master Nov 30, 2023
49 of 50 checks passed
@toriancrane toriancrane deleted the torian/azure-oidc branch November 30, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants