Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Redshift Glue ETL examples in TypeScript and Python #1327

Merged
merged 4 commits into from
Dec 27, 2022
Merged

Add Redshift Glue ETL examples in TypeScript and Python #1327

merged 4 commits into from
Dec 27, 2022

Conversation

cnunciato
Copy link
Member

To accompany pulumi/pulumi-hugo#2345.

@cnunciato cnunciato requested a review from a team December 23, 2022 21:29
@pulumi-staging
Copy link

🍹 The Update for moolumi/k8s-ci-cluster/ff42611e776299dcfc0e92a5ee57c579da74534c-827 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-ff42611e776299dcfc0e92a5ee57c579da74534c-827  pulumi:pulumi:Stack                         create
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create

@cnunciato cnunciato mentioned this pull request Dec 23, 2022
Merged
@pulumi-staging
Copy link

🍹 The Update for moolumi/k8s-ci-cluster/a4c8eeb0d7622cd1312be206eb1793035c50b865-828 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-a4c8eeb0d7622cd1312be206eb1793035c50b865-828  pulumi:pulumi:Stack                         create
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create

@pulumi-staging
Copy link

🍹 The Update for moolumi/k8s-ci-cluster/fb454d8689988861306d7645443c3d0b66c9875a-829 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   k8s-ci-cluster-fb454d8689988861306d7645443c3d0b66c9875a-829  pulumi:pulumi:Stack                         create
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create

@pulumi-staging
Copy link

🍹 The Destroy for moolumi/k8s-ci-cluster/ff42611e776299dcfc0e92a5ee57c579da74534c-827 was successful.

Resource Changes

    Name                  Type                                        Operation
-   gke                   pulumi:providers:kubernetes                 delete
-   primary-node-pool     gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster  gcp:container/cluster:Cluster               delete
-   password              random:index/randomPassword:RandomPassword  delete

@pulumi-staging
Copy link

🍹 The Destroy for moolumi/k8s-ci-cluster/a4c8eeb0d7622cd1312be206eb1793035c50b865-828 was successful.

Resource Changes

    Name                  Type                                        Operation
-   gke                   pulumi:providers:kubernetes                 delete
-   primary-node-pool     gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster  gcp:container/cluster:Cluster               delete
-   password              random:index/randomPassword:RandomPassword  delete

@pulumi-staging
Copy link

🍹 The Destroy for moolumi/k8s-ci-cluster/fb454d8689988861306d7645443c3d0b66c9875a-829 was successful.

Resource Changes

    Name                  Type                                        Operation
-   gke                   pulumi:providers:kubernetes                 delete
-   primary-node-pool     gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster  gcp:container/cluster:Cluster               delete
-   password              random:index/randomPassword:RandomPassword  delete

@scottslowe
Copy link
Contributor

It looks like there are some lint failures in the TypeScript files; I'll hold off on approving until we determine if those lint failures need to be addressed.

@cnunciato
Copy link
Member Author

Lint issues addressed @scottslowe!

@cnunciato
Copy link
Member Author

cnunciato commented Dec 27, 2022 •
edited
Loading

I went ahead and ran black against the Python files as well just to make sure those are good, too. Assuming there aren't any other issues, it'd be good to merge these because of the links at the end of the blog post that point to them. Thank you!

@pulumi-staging
Copy link

🍹 The Update for moolumi/k8s-ci-cluster/fa214a0b391d1251fe19d352f1332279f878edd3-835 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-fa214a0b391d1251fe19d352f1332279f878edd3-835  pulumi:pulumi:Stack                         create
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create

@pulumi-staging
Copy link

🍹 The Update for moolumi/k8s-ci-cluster/f5dd32e64a1dcc26b838bcffc83b42a3bfaf1413-836 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-f5dd32e64a1dcc26b838bcffc83b42a3bfaf1413-836  pulumi:pulumi:Stack                         create

@pulumi-staging
Copy link

🍹 The Destroy for moolumi/k8s-ci-cluster/fa214a0b391d1251fe19d352f1332279f878edd3-835 was successful.

Resource Changes

    Name                  Type                                        Operation
-   gke                   pulumi:providers:kubernetes                 delete
-   primary-node-pool     gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster  gcp:container/cluster:Cluster               delete
-   password              random:index/randomPassword:RandomPassword  delete

@pulumi-staging
Copy link

🍹 The Destroy for moolumi/k8s-ci-cluster/f5dd32e64a1dcc26b838bcffc83b42a3bfaf1413-836 was successful.

Resource Changes

    Name                  Type                                        Operation
-   gke                   pulumi:providers:kubernetes                 delete
-   primary-node-pool     gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster  gcp:container/cluster:Cluster               delete
-   password              random:index/randomPassword:RandomPassword  delete

scottslowe
scottslowe approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@scottslowe scottslowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottslowe scottslowe merged commit e2e5eb4 into master Dec 27, 2022
@scottslowe scottslowe deleted the cnunciato/redshift-glue-etl branch December 27, 2022 21:53
@pulumi-staging pulumi-staging bot had a problem deploying to pulumi/aws-ts-s3-folder/dev December 27, 2022 21:55 Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottslowe scottslowe scottslowe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cnunciato @scottslowe