Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gcp.cloudfunctions.HttpCallbackFunction typings #1300

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

cnunciato
Copy link
Contributor

To unbreak this example, this PR changes the types of the callback parameters in this example to any while we investigate pulumi/pulumi-gcp#939.

Fixes #1294.

@pulumi-staging
Copy link

pulumi-staging bot commented Nov 3, 2022

🍹 The Update for stack moolumi/k8s-ci-cluster/ac289ac11a7d1553cc01ec601ea95cf133da5676-792 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-ac289ac11a7d1553cc01ec601ea95cf133da5676-792  pulumi:pulumi:Stack                         create

@pulumi-staging
Copy link

pulumi-staging bot commented Nov 4, 2022

🍹 The Destroy for stack moolumi/k8s-ci-cluster/ac289ac11a7d1553cc01ec601ea95cf133da5676-792 was successful.

Resource Changes

    Name                  Type                                        Operation
-   gke                   pulumi:providers:kubernetes                 delete
-   primary-node-pool     gcp:container/nodePool:NodePool             delete
-   password              random:index/randomPassword:RandomPassword  delete
-   ephemeral-ci-cluster  gcp:container/cluster:Cluster               delete

@cnunciato cnunciato requested a review from a team November 4, 2022 14:44
Copy link
Contributor

@scottslowe scottslowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I also tested to verify it works)

@cnunciato cnunciato merged commit 29a72ca into master Nov 4, 2022
@pulumi-bot pulumi-bot deleted the cnunciato/examples-1294 branch November 4, 2022 17:24
@pulumi-staging pulumi-staging bot had a problem deploying to pulumi/aws-ts-s3-folder/dev November 4, 2022 17:25 Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcp-ts-functions doesn't work
2 participants