Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure aws-js-s3-folder does not run tsc #1288

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Sep 28, 2022

Since we reuse this example as a benchmark, it can be interesting to compare it against aws-ts-s3-folder with the same functionality to estimate TypeScript overhead. However without this switch, it runs TypeScript compilation anyway.

@t0yv0 t0yv0 requested a review from dixler September 28, 2022 15:20
Copy link
Contributor

@dixler dixler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pulumi-staging
Copy link

🍹 The Update for stack moolumi/k8s-ci-cluster/fd4e879b29d2a9d35864f5fb1c4809212a43fea1-777 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   k8s-ci-cluster-fd4e879b29d2a9d35864f5fb1c4809212a43fea1-777  pulumi:pulumi:Stack                         create
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create

@t0yv0 t0yv0 merged commit f1dee0f into master Sep 28, 2022
@t0yv0 t0yv0 deleted the t0yv0/speedup-aws-js-s3-folder branch December 6, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants