Fix gcp-java-gke-hello-world example #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @pawelprazak |
4 tasks
dixler
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
LGTM after:
kdixler@kdixler-20xw004aus ..ents/examples/gcp-java-gke-hello-world (git)-[t0yv0/fix-gcp-java-gke-hello-world] % pulumi config set gcp:project pulumi-development
Please choose a stack, or create a new one: dev
kdixler@kdixler-20xw004aus ..ents/examples/gcp-java-gke-hello-world (git)-[t0yv0/fix-gcp-java-gke-hello-world] % pulumi config set gcp:zone us-west1
kdixler@kdixler-20xw004aus ..ents/examples/gcp-java-gke-hello-world (git)-[t0yv0/fix-gcp-java-gke-hello-world] % pulumi pre
Previewing update (dev)
View Live: https://app.pulumi.com/dixler/gcp-java-gke-hello-world/dev/previews/f7922f1b-074d-466e-8e83-c8a449d55685
Type Name Plan
+ pulumi:pulumi:Stack gcp-java-gke-hello-world-dev create
+ ├─ gcp:container:Cluster helloworld create
+ ├─ gcp:container:NodePool primary-node-pool create
+ ├─ pulumi:providers:kubernetes helloworld create
+ ├─ kubernetes:core/v1:Namespace helloworld create
+ ├─ kubernetes:core/v1:Service helloworld create
+ └─ kubernetes:apps/v1:Deployment helloworld create
Outputs:
clusterName : "helloworld-c0ad4dd"
deploymentName : output<string>
kubeconfig : output<string>
masterVersion : "1.24.3-gke.200"
namespaceName : output<string>
serviceName : output<string>
servicePublicIP: output<string>
Resources:
+ 7 to create
I notice that running an initial pulumi pre is slow to give feedback on what it's doing for this example. Might we consider adding spinners, etc. to indicate to the user what pulumi is currently doing?
The error message could be better. opened pulumi/pulumi-java#785 and added it to the epic
pawelprazak
reviewed
Aug 11, 2022
| ContainerFunctions.getEngineVersions() | ||
| .thenApply(GetEngineVersionsResult::latestMasterVersion).join() | ||
| ); | ||
| final var masterVersion = ctx.config().get("masterVersion").map(Output::of) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO test: