fix 404 and a few link texts in azure aks example #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susanev
commented
Jun 2, 2022
classic-azure-ts-aks-mean/README.md
Outdated
| @@ -94,7 +94,7 @@ npm install | |||
|
|
|||
| One of the interesting aspects of this example is the way it demonstrates how easy it is to use | |||
| Azure resources to configure Kubernetes resources, without the need for intermediate APIs such as | |||
| [OSBA](https://osba.sh/). In particular, this example uses the connection strings exposed by the | |||
| [OSBA](https://github.com/Azure/open-service-broker-azure). In particular, this example uses the connection strings exposed by the | |||
There was a problem hiding this comment.
is this the best link to use?
mikhailshilkov
approved these changes
Jun 2, 2022
jkodroff
approved these changes
Jun 2, 2022
|
Open Service Broker (for Azure)
…On Thu, Jun 2, 2022 at 9:12 AM Mikhail Shilkov ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM. I don't know what OSBA is, but the link looks good.
—
Reply to this email directly, view it on GitHub
<#1226 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB77TQVJZVWXJIYTTHR6J23VNDMP5ANCNFSM5XVNWBYQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
susanev
commented
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.