Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct image name and use relative path for Docker context #1152

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

matsest
Copy link
Contributor

@matsest matsest commented Jan 20, 2022

Fixes two minor error + an update in the README to get this example up and running:

  1. Docker image name should not contain "https://" in the name.

Fixes:

    error: an unhandled error occurred: program exited with non-zero exit code: 1

    error: program failed: waiting for RPCs: https://<reg>.azurecr.io/node-app should not contain a tag: //<reg>.azurecr.io/node-app
    exit status 1
  1. Path to Dockerfile context should be relative ("./" vs absolute "/").

Fixes:

  docker:image:Image (node-app):
    error: unable to prepare context: path "/node-app" not found
  1. Use a valid region for container apps in Azure. Currently this is limited to canadacentral and northeurope in public environments.

Fixes:

  azure-native:web/v20210301:KubeEnvironment (kubeEnvironment):
    error: Code="LocationNotAvailableForResourceType" Message="The provided location 'westus2' is not available for resource type 'Microsoft.Web/kubeEnvironments'. List of available regions for the resource type is 'northcentralusstage,westcentralus,eastus,westeurope,jioindiawest,northeurope,canadacentral'."

Tested with:

  • pulumi v3.22.1
  • go version go1.16 linux/amd64
  • Docker version 20.10.11, build dea9396

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR

Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikhailshilkov mikhailshilkov merged commit 993d028 into pulumi:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants