Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Crosswalk API Gateway multi-language examples #1122

Merged
merged 28 commits into from
Dec 9, 2021

Conversation

danielrbradley
Copy link
Member

Create updated examples for AWS API Gateway to go along with updating the main guide (pulumi/pulumi-hugo#867).

  • Create comparible examlpes in Typescript, Python and Go
  • Create static (S3), Lambda and HTTP proxy routes
  • Create Cognito and Lambda authorizers
  • All examples and instructions tested locally

@danielrbradley danielrbradley self-assigned this Nov 23, 2021
@danielrbradley danielrbradley changed the title Add Crosswalk APIGateway multi-language examples Add Crosswalk API Gateway multi-language examples Nov 23, 2021
Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great to me. Is C# coming?

aws-apigateway-go-routes/handler/handler.go Show resolved Hide resolved
aws-apigateway-py-routes/__main__.py Outdated Show resolved Hide resolved
aws-apigateway-go-routes/main.go Show resolved Hide resolved
- Re-tested all examples work with fixed provider version.
- Fix missing regional provider in python DNS setup.
- Fix Go zone lookup and applies.
Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question

aws-apigateway-go-routes/main.go Show resolved Hide resolved
@danielrbradley danielrbradley merged commit 5b1b42e into master Dec 9, 2021
@pulumi-bot pulumi-bot deleted the danielrbradley/apigateway branch December 9, 2021 11:35
@lukehoban
Copy link
Member

🎉

dixler pushed a commit that referenced this pull request Jan 21, 2022
* Draft TS API Gateway example

* Fix up example from testing

* First draft of python API gateway example

* Fix a bunch of python issues

* Fix provider errors

* Draft API Gateway Go example

* Fix bugs found in testing

* Add testing of Cognito token

* Implement Cognito testing

* Fix line break

* Fix lint errors

* Spike pure Go example

* Fix go handler setup

* Add copyright notices

* Move go lambdas into own file

- Remove unused TS import

* Remove lambdas suffix

* Draft API Key examples

* Outline swagger route

- Need to create lambda permission but depends on pulumi/pulumi-aws-apigateway#12

* Tidy up API Key examples

* Simplify swagger route example

- Remove need for manual lambda permission.

* Fix comments

* Add full-api swagger examples

* Enable Typescript API Key example

- Tested again pre-release of package.

* Add TS custom domain

* Draft Python and Go DNS setup

* Final tweaks & formatting in line with docs changes

- Add DNS testing to all READMEs

* Fix TS lint errors

* Upgrade to aws-apigateway v0.0.5

- Re-tested all examples work with fixed provider version.
- Fix missing regional provider in python DNS setup.
- Fix Go zone lookup and applies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants