-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Crosswalk API Gateway multi-language examples #1122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look great to me. Is C# coming?
- Remove unused TS import
- Need to create lambda permission but depends on pulumi/pulumi-aws-apigateway#12
- Remove need for manual lambda permission.
- Tested again pre-release of package.
- Add DNS testing to all READMEs
- Re-tested all examples work with fixed provider version. - Fix missing regional provider in python DNS setup. - Fix Go zone lookup and applies.
mikhailshilkov
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one question
🎉 |
dixler
pushed a commit
that referenced
this pull request
Jan 21, 2022
* Draft TS API Gateway example * Fix up example from testing * First draft of python API gateway example * Fix a bunch of python issues * Fix provider errors * Draft API Gateway Go example * Fix bugs found in testing * Add testing of Cognito token * Implement Cognito testing * Fix line break * Fix lint errors * Spike pure Go example * Fix go handler setup * Add copyright notices * Move go lambdas into own file - Remove unused TS import * Remove lambdas suffix * Draft API Key examples * Outline swagger route - Need to create lambda permission but depends on pulumi/pulumi-aws-apigateway#12 * Tidy up API Key examples * Simplify swagger route example - Remove need for manual lambda permission. * Fix comments * Add full-api swagger examples * Enable Typescript API Key example - Tested again pre-release of package. * Add TS custom domain * Draft Python and Go DNS setup * Final tweaks & formatting in line with docs changes - Add DNS testing to all READMEs * Fix TS lint errors * Upgrade to aws-apigateway v0.0.5 - Re-tested all examples work with fixed provider version. - Fix missing regional provider in python DNS setup. - Fix Go zone lookup and applies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create updated examples for AWS API Gateway to go along with updating the main guide (pulumi/pulumi-hugo#867).