Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python examples to use fn_output forms where appropriate #1095

Merged
merged 13 commits into from
Nov 6, 2021

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Oct 7, 2021

Context: pulumi/pulumi#7948

Updates Python examples to use $fn_output feature.

@t0yv0
Copy link
Member Author

t0yv0 commented Oct 7, 2021

Progress: Py 1/67

@t0yv0
Copy link
Member Author

t0yv0 commented Oct 7, 2021

Completed eye-balling all Python examples Py 67/67 - since human error is possible, could have omitted something.

This will need a fresh look. Also I am thinking that we should fix pulumi/pulumi#8172 as a pre-requisite and fix the code to use direct calls and no workarounds. In a lot of the places 8172 is a show-stopper.

@t0yv0 t0yv0 changed the title WIP: update Python examples to use fn_output forms where appropriate Update Python examples to use fn_output forms where appropriate Oct 18, 2021
@t0yv0 t0yv0 marked this pull request as ready for review November 3, 2021 22:40
@t0yv0
Copy link
Member Author

t0yv0 commented Nov 3, 2021

pulumi/pulumi#8172 fixed. Previous CI failures were hitting it. Let's see it if passes this time.

@t0yv0 t0yv0 requested a review from a team November 3, 2021 22:41
@t0yv0
Copy link
Member Author

t0yv0 commented Nov 4, 2021

CI failure indicating pulumi/pulumi#8172 has not rolled out to pulumi-azure-native yet.

@t0yv0
Copy link
Member Author

t0yv0 commented Nov 6, 2021

The fix is rolled out and we have a ✅ PTAL.

@t0yv0 t0yv0 merged commit 569bcc4 into master Nov 6, 2021
@t0yv0 t0yv0 deleted the t0yv0/py-fn-output branch November 6, 2021 04:14
dixler pushed a commit that referenced this pull request Jan 21, 2022
* Update aws-django-voting-app

* Update azure-py-aks-helm

* Update azure-py-eks

* Update azure-py-appservice-docker

* Update azure-py-appservice

* Update azure-py-cosmosdb-logicapp

* Update azure-py-minecraft-server/

* Updated azure-py-webserver

* Update classic-azure-py-msi-keyvault-rbac

* Update classic-azure-py-webserver-component

* Update libvirt-py-vm

* Undo workaround
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants