Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include missing dependencies for testing-unit-ts #1059

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Conversation

leezen
Copy link
Contributor

@leezen leezen commented Aug 12, 2021

No description provided.

@leezen
Copy link
Contributor Author

leezen commented Aug 12, 2021

Interesting -- this somehow still fails the test and it claims it cannot find the typescript module...

@leezen
Copy link
Contributor Author

leezen commented Aug 12, 2021

Ah, I think it's b/c the test is using the global mocha and ts-node -- I don't think we actually need to do that, so I'll update the workflow.

Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants