Bug fix: Allow false to be set in the config #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code used the logical OR operator so that if the value in the config was false, it would be set to true. This made it impossible to set it to false in the config. This commit changes that to the nullish coalescing operator so that it will only default to true if no value is set.
|
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR |
leezen
approved these changes
Jun 28, 2021
|
Thanks for the submission! |
dixler
pushed a commit
that referenced
this pull request
Jan 21, 2022
The old code used the logical OR operator so that if the value in the config was false, it would be set to true. This made it impossible to set it to false in the config. This commit changes that to the nullish coalescing operator so that it will only default to true if no value is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code used the logical OR operator so that if the value in the config was false, it would be set to true. This made it impossible to set it to false in the config. This commit changes that to the nullish coalescing operator so that it will only default to true if no value is set.