Add container example #1
Conversation
| @@ -0,0 +1,71 @@ | |||
| # Copied from https://github.com/Azure-Samples/azure-voting-app-redis | |||
There was a problem hiding this comment.
If we intend to re-use the code from that example, we'll need to appropriately LICENSE this and repo (or to the voting-app folder) and likely add copyright information along the lines of: https://softwareengineering.stackexchange.com/questions/277688/if-i-fork-a-project-on-github-that-is-licensed-under-mit-how-to-i-handle-the-at
There was a problem hiding this comment.
Good point! Filed #2 so I don't lose track.
| "@types/node-fetch": "^1.6.7", | ||
| "node-fetch": "^1.7.3", | ||
| "redis": "^2.8.0" | ||
| } |
There was a problem hiding this comment.
I don't think you use any of these dependencies, so you can remove these from package.json.
| }, | ||
| }); | ||
|
|
||
| frontend.getEndpoint().then(e => e.hostname).then(hostname => console.log(`URL: ${hostname}`)); |
There was a problem hiding this comment.
With the fixes in master now - you can replace these lines with:
frontend.getEndpoint().then(e => console.log(`https://${e.hostname}:${e.port}`));
With the changes in pulumi/pulumi#581, you'll be able to replace with:
export let frontendUrl = frontend.getEndpoint().then(e => `https://${e.hostname}:${e.port}`);There was a problem hiding this comment.
This is AWESOME! Even the first change is so much better.
|
Thanks for the review! I filed #3 to add the readme. |
No description provided.