Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt new Redis terminology #133

Closed
joeduffy opened this issue Sep 12, 2018 · 1 comment
Closed

Adopt new Redis terminology #133

joeduffy opened this issue Sep 12, 2018 · 1 comment
Assignees
Milestone

Comments

@joeduffy
Copy link
Member

Per https://twitter.com/antirez/status/1039443441472688128, Redis is changing its terminology from master/slave to master/replica. Let's proactively go through our various examples that use Redis -- like the Kubernetes guestbook -- and make these same changes.

@joeduffy joeduffy added this to the 0.18 milestone Sep 12, 2018
@hausdorff
Copy link
Contributor

This is a good idea. In other repositories I actually proactively called it master/agent (following in the footsteps of Mesos, which made a similar transition ~2 years ago). When we re-implemented all these examples for the examples repo, we ended up in where we are now out of carelessness: I wrote a small vscode extension to auto-transform YAML to Pulumi, and this was an artifact of that.

We should therefore fix it.

ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this issue Sep 7, 2019
ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this issue Sep 13, 2019
dixler pushed a commit that referenced this issue Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants