axi_pkg: keep hardcoded value in typedef for vivado ip packager #293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ From issue #292 ]
Since commit fe4e020 the typedef
axi_pkg::burst_t
now relies on a Verilog parameterBurstWidth
.axi/src/axi_pkg.sv
Line 46 in fd60be8
In Occamy emulation we use these typedefs at the ports of a custom packaged Vivado IP.
But Vivado requires that "the IP ports are contained within the port description of the HDL file" (c.f. doc page 14).
So custom Vivado IPs can't use
axi_pkg::burst_t
at their top anymore (similar issue on this support thread)We could maybe define the typdef with a numerical value and then the parameter based on the
$size
of this typedef.See proposition in d2f98d6