Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axi_pkg: keep hardcoded value in typedef for vivado ip packager #293

Merged
merged 2 commits into from
May 8, 2023

Conversation

CyrilKoe
Copy link
Contributor

[ From issue #292 ]

Since commit fe4e020 the typedefaxi_pkg::burst_t now relies on a Verilog parameter BurstWidth.

typedef logic [BurstWidth-1:0] burst_t;

In Occamy emulation we use these typedefs at the ports of a custom packaged Vivado IP.

But Vivado requires that "the IP ports are contained within the port description of the HDL file" (c.f. doc page 14).
So custom Vivado IPs can't use axi_pkg::burst_t at their top anymore (similar issue on this support thread)

We could maybe define the typdef with a numerical value and then the parameter based on the $size of this typedef.
See proposition in d2f98d6

@CyrilKoe CyrilKoe linked an issue Mar 29, 2023 that may be closed by this pull request
@thommythomaso thommythomaso self-assigned this May 8, 2023
@thommythomaso thommythomaso merged commit 413f7c1 into master May 8, 2023
@thommythomaso thommythomaso deleted the issue/axi_pkg_typedef branch May 8, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

axi_pkg::LenWidth not compatible with vivado IP packager
2 participants