Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #3189

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Update dependencies #3189

merged 1 commit into from
Dec 16, 2019

Conversation

YasharF
Copy link
Contributor

@YasharF YasharF commented Oct 18, 2019

This is a housekeeping PR to address some of the out-of-date dependencies per https://github.com/pugjs/pug#dependency-status. It only includes updates that are not breaking pug tests. I have verified these changes by running the following commands in order:

npm run clean
npm run bootstrap
npm run pretest
npm run test
npm run coverage

The output of npm run test:

> pug-monorepo@ pretest /mnt/c/temp/pug
> lerna run pretest

lerna notice cli v3.10.8
lerna info versioning independent
lerna info Executing command in 1 package: "yarn run pretest"
lerna info run Ran npm script 'pretest' in 'pug-runtime' in 1.3s:
yarn run v1.19.1
$ npm run prepublish

> [email protected] prepublish /mnt/c/temp/pug/packages/pug-runtime
> node prepublish

Done in 0.96s.
lerna success run Ran npm script 'pretest' in 1 package in 1.3s:
lerna success - pug-runtime
yasharf@Orcus:/mnt/c/temp/pug$ npm run test

> pug-monorepo@ pretest /mnt/c/temp/pug
> lerna run pretest

lerna notice cli v3.10.8
lerna info versioning independent
lerna info Executing command in 1 package: "yarn run pretest"
lerna info run Ran npm script 'pretest' in 'pug-runtime' in 1.3s:
yarn run v1.19.1
$ npm run prepublish

> [email protected] prepublish /mnt/c/temp/pug/packages/pug-runtime
> node prepublish

Done in 0.94s.
lerna success run Ran npm script 'pretest' in 1 package in 1.3s:
lerna success - pug-runtime

> pug-monorepo@ test /mnt/c/temp/pug
> jest

 PASS  packages/pug-runtime/test/index.test.js
 PASS  packages/pug-attrs/test/index.test.js
 PASS  packages/pug/test/error.reporting.test.js (5.641s)
 PASS  packages/pug-walk/test/index.test.js
 PASS  packages/pug-error/test/index.test.js
 PASS  packages/pug-lexer/test/check-lexer-functions.test.js
(node:6136) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
 PASS  packages/pug/test/pug.test.js (6.435s)
 PASS  packages/pug-strip-comments/test/index.test.js
 PASS  packages/pug-filters/test/filter-aliases.test.js
 PASS  packages/pug/test/eachOf/index.test.js
 PASS  packages/pug/test/run-syntax-errors.test.js
 PASS  packages/pug-linker/test/index.test.js
 PASS  packages/pug-filters/test/index.test.js
 PASS  packages/pug-lexer/test/index.test.js
 PASS  packages/pug-filters/test/per-filter-options-applied-to-nested-filters.test.js
 PASS  packages/pug-load/test/index.test.js
 PASS  packages/pug/test/extends-not-top-level/index.test.js
 PASS  packages/pug-parser/test/index.test.js
 PASS  packages/pug/test/run-es2015.test.js
 PASS  packages/pug/test/examples.test.js
 PASS  packages/pug/test/regression-2436/index.test.js
 PASS  packages/pug/test/markdown-it/index.test.js
 PASS  packages/pug/test/duplicate-block/index.test.js
 PASS  packages/pug/test/shadowed-block/index.test.js
 PASS  packages/pug-parser/test/no-unnecessary-blocks.test.js
 PASS  packages/pug/test/run.test.js (6.269s)

Test Suites: 26 passed, 26 total
Tests:       645 passed, 645 total
Snapshots:   326 passed, 326 total
Time:        17.901s
Ran all test suites.

The output of npm run coverage

> pug-monorepo@ coverage /mnt/c/temp/pug
> jest --coverage

 PASS  packages/pug-runtime/test/index.test.js
 PASS  packages/pug-attrs/test/index.test.js
 PASS  packages/pug-walk/test/index.test.js
 PASS  packages/pug-error/test/index.test.js
 PASS  packages/pug/test/error.reporting.test.js (7.176s)
 PASS  packages/pug-lexer/test/check-lexer-functions.test.js
(node:6206) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
 PASS  packages/pug/test/pug.test.js (8.206s)
 PASS  packages/pug-filters/test/filter-aliases.test.js
 PASS  packages/pug-strip-comments/test/index.test.js
 PASS  packages/pug/test/eachOf/index.test.js
 PASS  packages/pug/test/run-syntax-errors.test.js
 PASS  packages/pug-linker/test/index.test.js
 PASS  packages/pug-filters/test/index.test.js
 PASS  packages/pug-filters/test/per-filter-options-applied-to-nested-filters.test.js
 PASS  packages/pug-lexer/test/index.test.js
 PASS  packages/pug-load/test/index.test.js
 PASS  packages/pug/test/extends-not-top-level/index.test.js
 PASS  packages/pug-parser/test/index.test.js
 PASS  packages/pug/test/run-es2015.test.js
 PASS  packages/pug/test/examples.test.js
 PASS  packages/pug/test/regression-2436/index.test.js
 PASS  packages/pug/test/markdown-it/index.test.js
 PASS  packages/pug/test/duplicate-block/index.test.js
 PASS  packages/pug/test/shadowed-block/index.test.js
 PASS  packages/pug-parser/test/no-unnecessary-blocks.test.js
 PASS  packages/pug/test/run.test.js (6.768s)
------------------------------------|----------|----------|----------|----------|-------------------|
File                                |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
------------------------------------|----------|----------|----------|----------|-------------------|
All files                           |    93.91 |    89.95 |     94.8 |    95.62 |                   |
 packages/pug-attrs                 |      100 |      100 |      100 |      100 |                   |
  index.js                          |      100 |      100 |      100 |      100 |                   |
 packages/pug-code-gen              |    94.66 |    91.12 |    97.56 |    95.11 |                   |
  index.js                          |    94.66 |    91.12 |    97.56 |    95.11 |... 91,292,294,351 |
 packages/pug-error                 |    96.67 |      100 |    66.67 |    96.67 |                   |
  index.js                          |    96.67 |      100 |    66.67 |    96.67 |                40 |
 packages/pug-filters               |      100 |      100 |      100 |      100 |                   |
  index.js                          |      100 |      100 |      100 |      100 |                   |
 packages/pug-filters/lib           |    96.55 |    89.58 |      100 |    96.55 |                   |
  handle-filters.js                 |    98.44 |    92.11 |      100 |    98.44 |               102 |
  run-filter.js                     |     91.3 |       80 |      100 |     91.3 |             33,34 |
 packages/pug-filters/test          |      100 |      100 |      100 |      100 |                   |
  custom-filters.js                 |      100 |      100 |      100 |      100 |                   |
 packages/pug-lexer                 |    95.54 |    92.43 |    98.39 |    96.16 |                   |
  index.js                          |    95.54 |    92.43 |    98.39 |    96.16 |... 1488,1489,1490 |
 packages/pug-linker                |    98.15 |    97.26 |      100 |     98.1 |                   |
  index.js                          |    98.15 |    97.26 |      100 |     98.1 |            91,160 |
 packages/pug-load                  |    97.96 |    96.88 |      100 |    97.96 |                   |
  index.js                          |    97.96 |    96.88 |      100 |    97.96 |                18 |
 packages/pug-parser                |    90.93 |    84.48 |    97.73 |    92.64 |                   |
  index.js                          |    90.93 |    84.48 |    97.73 |    92.64 |... 9,990,991,1084 |
 packages/pug-parser/lib            |      100 |      100 |      100 |      100 |                   |
  inline-tags.js                    |      100 |      100 |      100 |      100 |                   |
 packages/pug-runtime               |      100 |    99.01 |      100 |      100 |                   |
  build.js                          |      100 |      100 |      100 |      100 |                   |
  index.js                          |      100 |    98.97 |      100 |      100 |               161 |
  wrap.js                           |      100 |      100 |      100 |      100 |                   |
 packages/pug-runtime/lib           |      100 |      100 |      100 |      100 |                   |
  dependencies.js                   |      100 |      100 |      100 |      100 |                   |
  internals.js                      |      100 |      100 |      100 |      100 |                   |
  sources.js                        |      100 |      100 |      100 |      100 |                   |
 packages/pug-strip-comments        |      100 |      100 |      100 |      100 |                   |
  index.js                          |      100 |      100 |      100 |      100 |                   |
 packages/pug-walk                  |    94.92 |     91.3 |      100 |    94.92 |                   |
  index.js                          |    94.92 |     91.3 |      100 |    94.92 |          25,98,99 |
 packages/pug/examples              |    98.67 |       50 |      100 |      100 |                   |
  attributes.js                     |      100 |      100 |      100 |      100 |                   |
  code.js                           |      100 |      100 |      100 |      100 |                   |
  dynamicscript.js                  |      100 |      100 |      100 |      100 |                   |
  each.js                           |      100 |      100 |      100 |      100 |                   |
  extend.js                         |      100 |      100 |      100 |      100 |                   |
  form.js                           |      100 |      100 |      100 |      100 |                   |
  includes.js                       |      100 |      100 |      100 |      100 |                   |
  layout-debug.js                   |       80 |       50 |      100 |      100 |                 9 |
  layout.js                         |      100 |      100 |      100 |      100 |                   |
  mixins.js                         |      100 |      100 |      100 |      100 |                   |
  rss.js                            |      100 |      100 |      100 |      100 |                   |
  text.js                           |      100 |      100 |      100 |      100 |                   |
  whitespace.js                     |      100 |      100 |      100 |      100 |                   |
 packages/pug/lib                   |    90.67 |    85.14 |    70.37 |    90.48 |                   |
  index.js                          |    90.67 |    85.14 |    70.37 |    90.48 |... 59,461,462,464 |
 packages/pug/test                  |    93.33 |       75 |      100 |    93.33 |                   |
  run-utils.js                      |    93.33 |       75 |      100 |    93.33 |          23,24,27 |
 packages/pug/test/temp             |    33.33 |    10.71 |       50 |      100 |                   |
  input-compileModuleFileClient.js  |    33.33 |    10.71 |       50 |      100 |             1,3,6 |
 scripts                            |      100 |      100 |      100 |      100 |                   |
  filename-serializer.js            |      100 |      100 |      100 |      100 |                   |
  prettier-javascript-serializer.js |      100 |      100 |      100 |      100 |                   |
------------------------------------|----------|----------|----------|----------|-------------------|

Test Suites: 26 passed, 26 total
Tests:       645 passed, 645 total
Snapshots:   326 passed, 326 total
Time:        21.893s
Ran all test suites.

@YasharF
Copy link
Contributor Author

YasharF commented Nov 22, 2019

I suspect this is also going to fix the consumer warning

npm WARN deprecated [email protected]: core-js@<3.0 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.

since, if I understood it correctly, [email protected] is getting pulled through "constantinople": "^3.0.1" via "babel-types": "^6.26.0" --- fixed by pugjs/constantinople@9902a79#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

@eerohakio
Copy link

eerohakio commented Feb 1, 2020

When is this change going to be released? As npmjs still has the old versions where using old constantinople.

@papandreou
Copy link

I'm also eagerly awaiting a new release of pug-code-gen with that updated constantinople, as it gets rid of babel-runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants