Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More testing and a better warning for tags with multiple attributes #1439

Merged
merged 1 commit into from
Feb 28, 2014
Merged

More testing and a better warning for tags with multiple attributes #1439

merged 1 commit into from
Feb 28, 2014

Conversation

ForbesLindesay
Copy link
Member

Adds filename and line number to the multiple attributes warning and increases code coverage.

Code Coverage Before:

Statements   : 97.39% ( 1380/1417 )
Branches     : 95% ( 741/780 )
Functions    : 95.81% ( 160/167 )
Lines        : 97.55% ( 1315/1348 )

Code Coverage After:

Statements   : 98.23% ( 1390/1415 )
Branches     : 96.53% ( 751/778 )
Functions    : 96.41% ( 161/167 )
Lines        : 98.44% ( 1326/1347 )

@ForbesLindesay ForbesLindesay deleted the more-tests branch February 28, 2014 11:48
@ForbesLindesay ForbesLindesay restored the more-tests branch February 28, 2014 11:49
ForbesLindesay added a commit that referenced this pull request Feb 28, 2014
@ForbesLindesay
Merge pull request #1439 from visionmedia/more-tests
a9026b5 
More testing and a better warning for tags with multiple attributes
@ForbesLindesay ForbesLindesay merged commit a9026b5 into master Feb 28, 2014
@ForbesLindesay ForbesLindesay deleted the more-tests branch February 28, 2014 12:48
@vendethiel
Copy link
Contributor

(A.K.A. thanks for your work !)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ForbesLindesay @vendethiel