[ImgBot] Optimize images #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![imgbot[bot]](https://avatars.githubusercontent.com/in/4706?s=60&v=4){kind=small}
*Total -- 454.15kb -> 369.09kb (18.73%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 93.13kb -> 62.33kb (33.07%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 39.53kb -> 27.93kb (29.36%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/512.png -- 37.95kb -> 27.92kb (26.42%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 16.51kb -> 12.56kb (23.94%) /doc/images/github_metadata_develbranch.png -- 64.04kb -> 49.36kb (22.92%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/256.png -- 15.88kb -> 12.70kb (20.02%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/128.png -- 7.12kb -> 5.73kb (19.56%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 3.29kb -> 2.68kb (18.56%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 1.43kb -> 1.25kb (13.14%) /doc/images/github_metadata_pullrequest.png -- 36.66kb -> 31.91kb (12.94%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/32.png -- 1.44kb -> 1.26kb (12.27%) /doc/images/jltypes.svg -- 120.36kb -> 116.92kb (2.86%) /doc/src/assets/logo-dark.svg -- 6.82kb -> 6.69kb (1.92%) /doc/src/assets/logo.svg -- 6.81kb -> 6.69kb (1.84%) /contrib/julia.svg -- 3.19kb -> 3.18kb (0.15%) Signed-off-by: ImgBotApp <[email protected]>
pthariensflame
pushed a commit
that referenced
this pull request
May 3, 2020
This reuses the machinery that gives good stacktraces when a user
calls wait on a Task. Since bind internally uses _wait2, this
machinery is bypassed currently.
Currently, julia throws an uninformative stacktrace in this situation:
julia> c = Channel(_ -> error("foo"))
Channel{Any}(sz_max:0,sz_curr:0)
julia> for i in c end
ERROR: foo
Stacktrace:
[1] iterate(::Channel{Any}) at ./channels.jl:459
[2] top-level scope at ./REPL[2]:1
With this change, the stacktrace is much more informative:
julia> for i in c end
ERROR: TaskFailedException:
foo
Stacktrace:
[1] error(::String) at ./error.jl:33
[2] (::var"#1#2")(::Channel{Any}) at ./REPL[4]:1
[3] (::Base.var"JuliaLang#652#653"{var"#1#2",Channel{Any}})() at ./channels.jl:129
Stacktrace:
[1] check_channel_state at ./channels.jl:167 [inlined]
[2] take_unbuffered(::Channel{Any}) at ./channels.jl:405
[3] take! at ./channels.jl:383 [inlined]
[4] iterate(::Channel{Any}, ::Nothing) at ./channels.jl:449
[5] iterate(::Channel{Any}) at ./channels.jl:448
[6] top-level scope at ./REPL[5]:1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beep boop. Your images are optimized!
Your image file size has been reduced by 19% 馃帀
Details
馃摑docs |
repo | 馃檵issues | 馃弲swag | 馃彧marketplace