Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AltBeacon Library Update #33

Merged
merged 6 commits into from
Jun 4, 2022
Merged

Conversation

praveen-gm
Copy link
Contributor

@praveen-gm praveen-gm commented Mar 14, 2022

  • Updated AltBeacon Library from 2.17.1 to 2.19.3, to support android apps targeting SDK 31 and above
    Apps Targeting S+ (version 31 and above) requires that an explicit value for android:exported
    Closes The library does not work on Android 12 #31

  • Updated Kotlin Version to 1.6.10

  • Updated CHANGELOG & pubspec version to 0.3.1

  • Updated Example App to run on the latest Flutter SDK and changed app's target SDK to 31

  • All Tests Passed

  • Tested on Physical Devices

    • Samsung A10s (Android 11)
    • Nokia 8.1 (Android 11)

@pszklarska
Copy link
Owner

pszklarska commented May 31, 2022

Hi @praveen-gm! Thank you for your PR and I'm sorry for the delay.

It looks good to me. However, there were some issues with the CI. It should be fixed by now, but GitHub Actions won't allow me to re-run it (as it's been more than 30 days), so can you please update your PR and push your changes again to trigger the CI?

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2022

Codecov Report

Merging #33 (14cb00e) into master (4613f3f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files           1        1           
  Lines          63       63           
=======================================
  Hits           59       59           
  Misses          4        4           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@praveen-gm
Copy link
Contributor Author

Hi @pszklarska, I've updated my PR to trigger the CI. It looks like the Pre-publishing failed due to missing credentials. Let me know if there's anything else.

@pszklarska
Copy link
Owner

Awesome, thanks @praveen-gm!
I fixed this issue with CI, so all you have to do now is to fix one conflict in the example/pubspec.lock and I'd be happy to merge your PR!

@praveen-gm
Copy link
Contributor Author

@pszklarska, I've pulled the changes from master and resolved conflicts at example/pubspec.lock

@pszklarska pszklarska merged commit 410b686 into pszklarska:master Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The library does not work on Android 12
3 participants