Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional fortran compiler, adjustable cmake config installation #2946

Merged
merged 5 commits into from
May 2, 2023

Conversation

loriab
Copy link
Member

@loriab loriab commented May 1, 2023

Description

User API & Changelog headlines

Dev notes & details

  • It turns out one can build a psi4 with Fortran extensions (detected, not compiled) w/o a Fortran compiler by letting the CXX compiler handle the linking. This is very useful on Windows where we want a clang-cl C/CXX compiler, but the only cohesive Fortran-including stack is the ming (gcc/g++/gfortran) one. So this adds an option psi4_SKIP_ENABLE_Fortran to not enable Fortran when the code otherwise would. It doesn't check that the circumstances are suitable (that is, all detected, none to-be-compiled). Works great on Windows (that's how the conda pkg has dkh); haven't tried it on Linux.
  • Increasingly, where the Config.cmake files get installed to is configurable, esp. as there's no one place cmake looks for linux/mac/win. So adding that option psi4_INSTALL_CMAKEDIR. You won't see a change unless you were customizing CMAKE_INSTALL_DATADIR.
  • also fix a couple install locations that were obvious for windows install.
  • stop testing the extra cli qcf tests for qcf master since those are run on mac, and it hangs.

Checklist

Status

  • Ready for review
  • Ready for merge

@loriab loriab added the build label May 1, 2023
@loriab loriab added this to the Psi4 1.8 milestone May 1, 2023
@loriab loriab mentioned this pull request May 2, 2023
7 tasks
@jturney jturney added this pull request to the merge queue May 2, 2023
Merged via the queue into psi4:master with commit 6e7e94b May 2, 2023
4 checks passed
@loriab loriab deleted the optfortran branch May 2, 2023 14:46
@loriab loriab mentioned this pull request May 2, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants