Modernize BasisSet::print_detail_cfour

[TiborGY]

Description

Much like PR #2804, this PR is mostly about eliminating sprintf-related compiler warnings and modernizing C-style string handling to C++, this time in libmints' BasisSet::print_detail_cfour.

Dev notes & details

• Modernized BasisSet::print_detail_cfour(), highlights:
• No longer uses sprintf and a fixed-size char array
• Variables are made const wherever reasonable
• Use of std::find on doubles is replaced by new functions (none_of_equal and fpeq) that implement a fuzzy compare with a default tolerance of 1E-14. Probably no behaviour change in practice (unless someone has basis fns which differ in exponent by >0 but <1E-14), but it is usually not recommended to use == on FP types, which is what std::find does.
• The slater.chemie.uni-mainz.de URL has succumbed to link rot. Replaced with one that points to the latest version that is being preserved by the Internet Archive, both in the C++ and Python implementations.
• Ran clang-format on basisset.cc and basisset.h

Questions

• The new functions none_of_equal and fpeq are just living in basisset.cc and basisset.h right now. Would some other file be a better place to put them?

Checklist

• No new features
• Tests run by the CI are passing
• I do not have CFOUR, so I cannot really test if this breaks something. It should not, but the std::find change is behaviour-altering, albeit only in a corner case.

Status

• Ready for review
• Ready for merge

[loriab]

Formatting is great, but just in case part of your goal is to compare basissets at the .gbs file level, I wanted to let you know about https://github.com/psi4/psi4/blob/master/psi4/share/psi4/basis/primitives/diff_gbs.py . Thhe basis set exchange has one, too, -- I think https://github.com/MolSSI-BSE/basis_set_exchange/blob/master/basis_set_exchange/curate/diff.py

I'll look into the adcc errors. I think Max updated the conda packages recently.

[TiborGY]

This branch was waiting for #2804 to be merged, the original goal was just to properly fix for some compiler warnings, but I will need to re-read these changes myself, it has been waiting for months.

[loriab]

Nice modernization, thank you!

I've run the tests/cfour test suite and a partial cfour ccsd(t) many-body job with lots of ghost atoms, and all pass, so lgtm.

[loriab]

Conflicts are trivial, so please lmk if you want to handle the rebase or website UI resolve, or if I should, @TiborGY .

[TiborGY]

Conflicts are trivial, so please lmk if you want to handle the rebase or website UI resolve, or if I should, @TiborGY .

Thanks for the testing, conflicts resolved via the web-UI.
PS. Github decided to do a "merge-master-into-this" to resolve the conflict, LMK if that is a problem.