Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for QCFractal next beta10 #2929

Merged
merged 5 commits into from
May 1, 2023
Merged

Fix for QCFractal next beta10 #2929

merged 5 commits into from
May 1, 2023

Conversation

loriab
Copy link
Member

@loriab loriab commented Apr 24, 2023

Description

closes #2939

User API & Changelog headlines

  • fix bug where optimize(..., engine="geometric", molecule=mol) would not run
  • undo some hack fixes and make distributed driver runs through QCFractal "next" branch more reliable by making array qcvars shaped numpy arrays. Works with QCFractal >=v0.50beta10. Show examples of using get_psi_results() to prepare the results of distributed driver runs in "normal" psi4 way.

Dev notes & details

  • In the early days (before ddd entered psi4), all array-like pieces of AtomicResults came back as flat lists, so we had to "plump" them into e.g., (nat, 3) for gradient. Then, by the time of v1.6 and QCFractal master v15.8, the AtomicResults preserved all that, so we stopped using the plumper. Now in qcfractal next, they're back to lists again and qcvars have been mingled with other properties, so both separation and plumping are required.
  • promote get_psi_results as a drop-in replacement after running distributed. It sets up a dummy wfn and qcvariables, just like an internal run, so one doesn't have to deal with picking results off the AtomicResult QCSchema.
  • Added labels to tests (mostly findif) so that one can catch all ddd-using tests with pytest -m "findif and cbs and nbody"
  • set up a mechanism where can parameterize both pytests and ctests with a snowflake with minimum clutter.

Questions

  • This won't work with current qcf release. I'll ask @bennybp to mint a beta10, then this should work.

Checklist

Status

  • Ready for review (for review, the 4th commit has the material changes. 3rd are test changes. 1st & 2nd are labeling and syntax.)
  • Ready for merge

@loriab loriab added testing schema deploys or develops MolSSI/QCSchema labels Apr 24, 2023
@loriab loriab added this to the Psi4 1.8 milestone Apr 24, 2023
@@ -35,6 +35,7 @@
import abc
import copy
import logging
import pprint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is pprint used or just a debug leftover?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a debug leftover that I keep adding again and again, so I thought I'd leave it (until some linter confiscates it).

@loriab loriab added this pull request to the merge queue May 1, 2023
Merged via the queue into psi4:master with commit 3128f69 May 1, 2023
@loriab loriab deleted the qcf_beta10_2 branch August 1, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema deploys or develops MolSSI/QCSchema testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update to qcfractal beta10 for v1.8
3 participants