Do not compile unused functions in ccdensity #2696
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ccdensity::resort_tei()
appears to be completely unused, it is never called anywhere, it is notPSI_API
and it is commented out from CMake as well as at the declaration site. This is because it is part of an incomplete project to implement frozen-core CC gradients. Comment added at the declaration site to inform future devs about its status.There are also a bunch of functions which were only called by
resort_tei()
, or by functions only called fromresort_tei()
. They were enabled in CMake. Commented them out in CMake.Todos
ccdensity
:classify
,distribute
,file_build
,idx_error
andidx_permute
Status