Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dfocc tensor syntax update #2663

Merged
merged 1 commit into from
Aug 9, 2022
Merged

dfocc tensor syntax update #2663

merged 1 commit into from
Aug 9, 2022

Conversation

loriab
Copy link
Member

@loriab loriab commented Aug 8, 2022

Description

new SharedSomething -> make_shared in DFOCC.

REVIEW ONLY SECOND COMMIT (First commit is #2653)

This is PR No. 2 in the mega-dfocc-remp series.

Todos

  • This involves no substantive changes, only syntax. So no review or cursory review fine. It will clear 10k lines of clutter from further PRs.

Status

  • Ready for review
  • Ready for merge

@loriab loriab added this to the Psi4 1.7 milestone Aug 8, 2022
@loriab loriab added the cleanup For issues where the goal is to make Psi4 a little cleaner. label Aug 8, 2022
@JonathonMisiewicz
Copy link
Contributor

And just to be explicit, do not merge this in until #2653 is in. Reviews on that PR are appreciated.

@loriab loriab merged commit c680795 into psi4:master Aug 9, 2022
@loriab loriab deleted the combo_diis_only branch August 9, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup For issues where the goal is to make Psi4 a little cleaner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants