Test Directory Cleanup

[philipmnel]

Description

Cleanup of tests directory following #2555. Heals various typos preventing some tests from getting pytest registration as well as some discrepancies between ctest and pytest labels. Deletes many unused/broken tests.

Todos

• All unused optimizer tests deleted following discussion in clean up tests directory #2555.
• All unused sowreap tests deleted.
• cc5, scf11-freq-from-energies,dft-pbe0-2, dft-dsd, dft-dldf are all unused duplicates of other tests. Deleted.
• min-input Broken + unused. Deleted.
• fsapt-diff1 Unused + not a test. Deleted.
• dfmp2-freq1, dfmp2-freq2, props4 were unused but are passing, quick, and useful. These are saved and added to CMakeLists.txt.
• tester.py no longer erroneously complains about ecppint tests having mismatched labels.

Checklist

• All tests that were missing registrations are passing.

Status

• Ready for review
• Ready for merge

[JonathonMisiewicz]

For every duplicate test, I want to know where the duplicate is.

[philipmnel]

cc5 is a near duplicate of cc5a. The latter uses a smaller basis set as cc5 is very slow.
scf11-freq-from-energies is a near duplicate of fd-freq-energy-large with a slightly different geometry. The former does not pass without adjusting findif stepsize settings.
dft-pbe0-2 is duplicated verbatim in dft-custom-dhdf
dft-dsd is duplicated in dft-custom-dhdf with corrected reference values. Former does not pass.
dft-dldf is duplicated in dft-custom-mgga with corrected reference values. Former does not pass.

[JonathonMisiewicz]

Okay. Please rename cc5a to cc5 and update tests/cc_index.

[loriab]

looking good, thanks!

[loriab]

Thanks very much, including improving the tester script. Nice negative LOC!

[hokru]

lgtm. Merge conflicts need to be addressed before PR can continue.

[philipmnel]

Merge conflicts have been fixed.

[JonathonMisiewicz]

@loriab Is there a hold on merging this?

[loriab]

@loriab Is there a hold on merging this?

No hold; merge away.