Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DLPNO Doc Fix #2313

Merged
merged 2 commits into from
Oct 5, 2021
Merged

DLPNO Doc Fix #2313

merged 2 commits into from
Oct 5, 2021

Conversation

zachglick
Copy link
Contributor

@zachglick zachglick commented Oct 4, 2021 •
edited
Loading

Description

Fixes the DLPNO docs (PR #2093). I can now build the docs locally, although I still get the following warnings:

/theoryfs2/ds/glick/gits/psi4/objdir/doc/sphinxman/source/dlpnomp2.rst:90: WARNING: Undefined substitution referenced: "dlpno__pno_convergence".
/theoryfs2/ds/glick/gits/psi4/objdir/doc/sphinxman/source/dlpnomp2.rst:207: WARNING: Undefined substitution referenced: "dlpno__pno_convergence".

Update: Warnings are fixed thanks to a suggestion from Lori

Status

  • Ready for review
  • Ready for merge

loriab
loriab approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@loriab loriab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I don't see why your |dlpno__pno_convergence| shouldn't be processing correctly. I'll take a look the next time I'm running docs locally.

@loriab loriab added this to the Psi4 1.5 milestone Oct 4, 2021
@PeterKraus PeterKraus merged commit de731db into psi4:master Oct 5, 2021
@zachglick zachglick deleted the dlpno_docs branch October 5, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loriab loriab loriab approved these changes

@PeterKraus PeterKraus PeterKraus approved these changes

@JonathonMisiewicz JonathonMisiewicz JonathonMisiewicz approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
Psi4 1.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zachglick @loriab @PeterKraus @JonathonMisiewicz